testament: fix missing error reporting #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test's specification is invalid, it must not be joined, so that an error can be reported for it. Previously, a test with an invalid spec could be joined, which effectively discarded the error. The test was also neither run nor compiled, since no targets were enabled for the test, in that case.
zerbina
added
bug
saem
approved these changes
Sep 7, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
saem
reviewed
Sep 7, 2024
The line info of the assignment source expression didn't match the one expected by the test.
zerbina
force-pushed
the
testament-fix-join-bug
branch
from
5ec6403
to
d013b88
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix tests with invalid specs being silently ignored (they were neither
compiled nor run) when using
allorcat megatest.Details
The
isJoinableSpecprocedure didn't prevent tests with an invalidspec (
reInvalidSpec) from being joined, which overrode the failurewith
reJoined. Since the specs then had no target enabled, they werealso not included in the megatest.
A few invalid test specifications went by unnoticed due to this bug --
they're now fixed.